Hi Enric, Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra: > From: Chris Zhong <zyw@xxxxxxxxxxxxxx> > > Add a node for the cdn DP controller which is embedded in the rk3399 > SoC. > > Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++ It looks like there is no binding document at all for cdn-dp? At least I couldn't find one and the original series also didn't seem to include one. And while I don't see anything problematic right with the used properties right now, I'd think we should really have a binding and give dt-maintainers a chance to complain, before adding devicetree nodes based on it. I'd guess a mostly usable binding doc should already sit in the chromeos tree, which you could base a v2 of this series on? Thanks Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
