On Tue, 2014-02-11 at 23:51 +0100, Sebastian Hesselbarth wrote: > On 02/11/2014 11:33 PM, Kumar Gala wrote: > > Hmm, > > > > Wondering if this caused the issue: > > > > commit 105353145eafb3ea919f5cdeb652a9d8f270228e > > Author: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> > > Date: Tue Dec 3 14:52:00 2013 +0100 > > > > OF: base: match each node compatible against all given matches first > > [adding Arnd on Cc] > > Could be. I checked tty/serial/of_serial.c and it does not provide a > compatible for "fsl,ns16550". Does reverting the patch fix the issue > observed? > > I don't think the missing compatible is causing it, but of_serial > provides a DT match for .type = "serial" just to fail later on > with the error seen above. > > The commit in question reorders of_match_device in a way that match > table order is not relevant anymore. This can cause it to match > .type = "serial" first here. > > Rather than touching the commit, I suggest to remove the problematic > .type = "serial" from the match table. It is of no use anyway. Regardless of whether .type = "serial" gets removed, it seems wrong for of_match_node() to accept a .type-only match (or .name, or anything else that doesn't involve .compatible) before it accepts a compatible match other than the first in the compatible property. -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
