Hi Stefan, On Wed, Feb 07, 2018 at 10:33:24AM +0100, Stefan Wahren wrote: > Am 06.02.2018 um 17:27 schrieb Baruch Siach: > > On Tue, Feb 06, 2018 at 02:42:48PM +0100, Linus Walleij wrote: > >> On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@xxxxxxxxxx> wrote: > >> > >>> The Raspberry Pi 3 has a GPIO expander that controls, among others, the > >>> activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus > >>> that is not directly controlled from the ARM core. The VC4 firmware controls > >>> the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox > >>> interface. > >>> > >>> This series adds support for the RPi3 expander. > >>> > >>> The driver is ported from the downstream kernel at > >>> https://github.com/raspberrypi/linux/, branch rpi-4.9.y. > >>> > >>> Changes in v3: > >>> > >>> * Kconfig tweaks > >>> * Check rpi_exp_gpio_get_polarity() return value > >>> * Redundant header removal > >>> * Redundant platform_set_drvdata() call removal > >>> * Small coding style changes > >> All is looking pretty good. I see Rob had some last minute comments, > >> but please rebase and repost post v4.16-rc1 so we can get this merged, > >> we need to get this upstream. > > I was about to send v4 when I saw your email. I based v4 on current LinusT's > > tree as of e237f98a9c. I guess that affected files will not change before > > v4.16-rc1, but I can wait a few more days for -rc1. > > please also address the owner issue in the driver, which was reported by > kbuild test robot. I removed the .owner platform_driver field set from v4. The owner field in gpio_chip is still set. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
