On 02/07/2018 03:25 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Jan 31, 2018 at 8:19 AM, Rajendra Nayak <rnayak@xxxxxxxxxxxxxx> wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> new file mode 100644
>> index 000000000000..02520f19e4ca
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -0,0 +1,277 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +/ {
>> + model = "Qualcomm Technologies, Inc. SDM845";
>
> I'm fairly certain that "model" doesn't belong in the SoC .dtsi file.
> Only in the board .dts file.
>
>
>> + clocks {
>> + xo_board: xo_board {
>
> Just to make it explicit: see my comments in patch 3/3 in this series
> about using "_" in node names. I believe this should be:
>
> xo_board: xo-board {
>
>
>> + spmi_bus: qcom,spmi@c440000 {
>
> Drop the qcom in the node name. AKA, I believe this should be:
>
> spmi_bus: spmi@c440000 {
>
> Specifically the node name is supposed to be a generic component name
> then with an address. I see that Rob Herring said the same thing when
> he reviewed v1 of this patch just now (it seems like people are still
> commenting there, so make sure you collect the latest feedback from
> there when re-spinning).
yes, I'll make sure I fix up based on Robs' review of the v1.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
