On Wed, Feb 7, 2018 at 12:11 AM, Bai Ping <ping.bai@xxxxxxx> wrote:
> Add dtsi file for imx6sll.
>
> Signed-off-by: Bai Ping <ping.bai@xxxxxxx>
> ---
> arch/arm/boot/dts/imx6sll.dtsi | 811 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 811 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6sll.dtsi
>
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> new file mode 100644
> index 0000000..b87ee2b
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -0,0 +1,811 @@
> +/*
> + * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2017-2018 NXP.
> + *
> + * SPDX-License-Identifier: (GPL-2.0 OR MIT)
SPDX line should be the first one and it should start with //
> + */
> +
> +#include <dt-bindings/clock/imx6sll-clock.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include "imx6sll-pinfunc.h"
> +#include "skeleton.dtsi"
Please avoid including "skeleton.dtsi". We do not include it anyomre
in imx6 dtsi files.
> + intc: interrupt-controller@00a01000 {
No leading zeros, please.
Building it with W=1 would warn you about this.
Make sure the next version does not generate warnings with W=1.
> + mmdc: mmdc@021b0000 {
> + compatible = "fsl,imx6sll-mmdc", "fsl,imx6q-mmdc";
> + reg = <0x021b0000 0x4000>;
> + };
> +
> + rngb: rngb@021b4000 {
> + compatible = "fsl,imx6sl-rng", "fsl,imx-rng", "imx-rng";
These compatible strings are not documented.
> + reg = <0x021b4000 0x4000>;
> + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6SLL_CLK_DUMMY>;
> + };
> +
> + ocotp: ocotp-ctrl@021bc000 {
> + compatible = "fsl,imx6sll-ocotp", "syscon";
> + reg = <0x021bc000 0x4000>;
> + clocks = <&clks IMX6SLL_CLK_OCOTP>;
> + };
> +
> + csu: csu@021c0000 {
> + compatible = "fsl,imx6sll-csu";
This compatible strings is not documented.
> + reg = <0x021c0000 0x4000>;
> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
> + snvs_gpr: snvs-gpr@0x021c4000 {
> + compatible = "fsl, imx6sll-snvs-gpr";
Ditto.
> + reg = <0x021c4000 0x10000>;
> + };
> +
> + iomuxc_snvs: iomuxc-snvs@021c8000 {
> + compatible = "fsl,imx6sll-iomuxc-snvs";
Ditto.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
