On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote: > Use of_property_read_u32 functions to clean probe function. > > Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> > --- > [ ... ] > + > + if (enable_once) > watchdog_set_nowayout(xilinx_wdt_wdd, true); > - } watchdog_set_nowayout(xilinx_wdt_wdd, enable_once); would probably do as well (the function checks the flag as well). Nitpick, so Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html