2018-01-24 4:26 GMT+01:00 David Lechner <david@xxxxxxxxxxxxxx>: > On 01/20/2018 11:14 AM, David Lechner wrote: >> >> This removes all of the clock init code from da8xx-dt.c. This includes >> all of the OF_DEV_AUXDATA that was just used for looking up clocks. >> >> Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx> >> --- >> >> v6 changes: >> - removed misleading statement from commit message >> >> arch/arm/mach-davinci/da8xx-dt.c | 61 >> +--------------------------------------- >> 1 file changed, 1 insertion(+), 60 deletions(-) >> >> diff --git a/arch/arm/mach-davinci/da8xx-dt.c >> b/arch/arm/mach-davinci/da8xx-dt.c > > >> static void __init da850_init_machine(void) >> { >> - /* All existing boards use 100MHz SATA refclkpn */ >> - static const unsigned long sata_refclkpn = 100 * 1000 * 1000; >> - >> - int ret; >> - >> - ret = da8xx_register_usb20_phy_clk(false); >> - if (ret) >> - pr_warn("%s: registering USB 2.0 PHY clock failed: %d", >> - __func__, ret); >> - ret = da8xx_register_usb11_phy_clk(false); >> - if (ret) >> - pr_warn("%s: registering USB 1.1 PHY clock failed: %d", >> - __func__, ret); >> - >> - ret = da850_register_sata_refclk(sata_refclkpn); >> - if (ret) >> - pr_warn("%s: registering SATA REFCLK failed: %d", >> - __func__, ret); >> - >> - of_platform_default_populate(NULL, da850_auxdata_lookup, NULL); >> + of_platform_default_populate(NULL, NULL, NULL); > > > of_platform_default_populate() can actually be removed completely. > of_platform_default_populate_init() is called implicitly during > arch_initcall_sync > >> davinci_pm_init(); >> pdata_quirks_init(); >> } Hi David, this patch breaks nand on da850-lcdk (and probably on da850-evm) since the nand driver can no longer clk_get() the nand clock. We would need to keep the dev_auxdata at least for aemif. Thanks, Bartosz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html