Hi Sergei, On Mon, Feb 5, 2018 at 2:48 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 2/5/2018 4:32 PM, Geert Uytterhoeven wrote: >>> The initial R8A77980 SoC device tree including Cortex-A53 CPU, GIC, >>> timer, >>> CPG, RST, and SYSC. >>> >>> Based on the original (and large) patch by Vladimir Barinov. >>> >>> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> >> >> >> Thanks for your patch! >> >>> --- /dev/null >>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi >>> @@ -0,0 +1,122 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Device Tree Source for the r8a77980 SoC >>> + * >>> + * Copyright (C) 2018 Renesas Electronics Corp. >>> + * Copyright (C) 2018 Cogent Embedded, Inc. >>> + */ >>> + >>> +#include <dt-bindings/interrupt-controller/irq.h> >>> +#include <dt-bindings/interrupt-controller/arm-gic.h> >>> +#include <dt-bindings/clock/renesas-cpg-mssr.h> >> >> I think you want to leave out the above #include, as it will go upstream >> through a different path (you're already using hardcoded clock numbers, >> assuming the same). > > I still need CPG_{CORE|MOD}. You're right. Please ignore my comment. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html