On Fri, Feb 02, 2018 at 09:33:18PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 2, 2018 at 6:20 PM, Daniel Baluta <daniel.baluta@xxxxxxx> wrote:
> > +static int ak5558_set_dai_mute(struct snd_soc_dai *dai, int mute)
> > +{
> > + struct snd_soc_codec *codec = dai->codec;
> > + struct ak5558_priv *ak5558 = snd_soc_codec_get_drvdata(codec);
>
> > + int ndt = 0;
>
> It might be even
>
> int ndt = max(ak5558->fs ? 583000 / ak5558->fs : 5, 5);
Please don't encourage people to use the ternery operator like that, it
does nothing for legibility not to write out the conditionals.
> > +static const struct i2c_device_id ak5558_i2c_id[] = {
> > + { "ak5558", 0 },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, ak5558_i2c_id);
> I dunno if it's really helpful to have. Though it's up to Mark and you.
I don't care either way.
Attachment:
signature.asc
Description: PGP signature
