Hi, On Fri, Feb 02, 2018 at 10:01:51PM +0800, Icenowy Zheng wrote: > Allwinner V3s SoC features a DMA engine. > > Add it in the DTSI file. > > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx> > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi > index 443b083c6adc..20edebd983f0 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -178,6 +178,15 @@ > }; > > You have on extra line here > + dma: dma-controller@01c02000 { The leading 0 will generate a DT warning > + compatible = "allwinner,sun8i-v3s-dma"; > + reg = <0x01c02000 0x1000>; > + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu CLK_BUS_DMA>; > + resets = <&ccu RST_BUS_DMA>; > + #dma-cells = <1>; > + }; > + Since you have that extra line above, you can just drop this new line here. Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
Attachment:
signature.asc
Description: PGP signature