Hello Benoît, On Wed, Jan 31, 2018 at 01:05:14AM +0100, Benoît Thébaudeau wrote: > The eSDHC does not work properly if the SION bit is not set for the > bidirectional CMD signal, whatever the eSDHC instance and the selected > pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do > this for MX25_PAD_*__ESDHCn_CMD in imx25-pinfunc.h in order to enforce > this behavior for all boards. > > This had already been done for eSDHC1, but not for eSDHC2. Also, define > MX25_PAD_FEC_MDC__ESDHC2_CMD so that all the possible cases are covered > from now on. > > Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@xxxxxxxxx> > Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx> > --- > Changes v1 -> v2: > - Update eSDHC instance and port naming following the addition of "ARM: > dts: imx25-pinfunc: Use consistent naming for eSDHC". > - Reference the more verbose comment for MX25_PAD_SD1_CMD__ESDHC1_CMD > instead of copying the same less detailed comment everywhere > (suggested by Uwe). > --- > arch/arm/boot/dts/imx25-pinfunc.h | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/imx25-pinfunc.h b/arch/arm/boot/dts/imx25-pinfunc.h > index 2915c65a13c9..71a61c4c984f 100644 > --- a/arch/arm/boot/dts/imx25-pinfunc.h > +++ b/arch/arm/boot/dts/imx25-pinfunc.h > @@ -236,7 +236,8 @@ > #define MX25_PAD_LD8__LD8 0x0e8 0x2e0 0x000 0x00 0x000 > #define MX25_PAD_LD8__UART4_RXD 0x0e8 0x2e0 0x570 0x02 0x000 > #define MX25_PAD_LD8__FEC_TX_ERR 0x0e8 0x2e0 0x000 0x05 0x000 > -#define MX25_PAD_LD8__ESDHC2_CMD 0x0e8 0x2e0 0x4e0 0x06 0x000 > +/* See the comment for MX25_PAD_SD1_CMD__ESDHC1_CMD. */ I'd write: /* SION must be set, see the comment for MX25_PAD_SD1_CMD__ESDHC1_CMD. */ to at least mention SION here. Other than that the commit looks fine. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
