On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote: > The Spreadtrum SC9860 platform GPIO controller contains 16 groups and > each group contains 16 GPIOs. Each GPIO can set input/output and has > the interrupt capability. > +config GPIO_SPRD > + bool "Spreadtrum GPIO support" Either you have to put tristate here, or remove all redundant module_*() and MODULE_*() macros. Other than that looks fine to me, FWIW: Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html