On Tue 2018-01-30 00:20:31, Ladislav Michl wrote: > On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote: > > > > This adds device tree support to tlv320dac33.c. > > > > Signed-off-by: Pavel Machek <pavel@xxxxxx> > > > > diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt > > new file mode 100644 > > index 0000000..6cbd311 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt > > @@ -0,0 +1,32 @@ > > +Texas Instruments - tlv320dac33 Codec module > > + > > +The tlv320dac33 serial control bus communicates through I2C protocols. > > + > > +Required properties: > > + > > +- compatible - "ti,tlv320dac33" > > +- reg - I2C slave address > > + > > +Optional properties: > > + > > +- power-gpios - gpio pin to power the device, active high > > While driver used gpio in platform data, isn't it more likely > regulator which powers device? power-gpios = <&gpio2 28 0>; /* gpio_60 */ Looks like GPIO to me -- example is from Nokia N9. So this appears to be correct. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature