On 21/01/2018 01:12, Jonathan Cameron wrote:
On Wed, 17 Jan 2018 11:38:28 +0800
Phil Reid <preid@xxxxxxxxxxxxxxxxx> wrote:
Add implementation for Analog Devices AD5272 and AD5274 digital
potentiometer devices.
Signed-off-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx>
A couple more minor comments.
...
menu "Digital potentiometers"
+config AD5272
+ tristate "Analog Devices AD5272 Digital Potentiometer driver"
+ depends on I2C
+ help
+ Say yes here to build support for the Analog Devices AD5272
+ digital potentiometer chip.
You need to list he compatible parts here so that people looking for
the driver can find it. Usually the short text states 'and similar'
and the help text contains a list of parts. AD5274 is missing here.
ok
...
+ if (reset_gpio) {
+ udelay(1);
+ gpiod_set_value(reset_gpio, 1);
+ } else {
+ ad5272_write(data, AD5272_RESET, 0);
+ }
+ usleep_range(1000, 2000);
kernel coding conventions (and readability) put a blank line
before return statements.
ok
--
Regards
Phil Reid
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
