Thankyou Dave,
I will fix these in next version.
On 10/02/14 22:40, David Miller wrote:
> From: <srinivas.kandagatla@xxxxxx>
> Date: Fri, 7 Feb 2014 10:55:25 +0000
>
>> + if (dwmac->interface == PHY_INTERFACE_MODE_MII ||
>> + dwmac->interface == PHY_INTERFACE_MODE_GMII) {
>
> This is not indented correctly, the first character on the second line should
> line up exactly at the column after the openning parenthesis on the first
> line.
>
> The objective is not to indent using only TAB characters, which you
> are doing here.
>
> Rather, the objective is to use the appropriate number of TAB _and_
> space characters necessary to reach the proper column.
>
>> + const char *rs;
>> + err = of_property_read_string(np, "st,tx-retime-src", &rs);
>
> Please add an empty line after the local variable declaration.
>
>> + if (!strcasecmp(rs, "clk_125"))
>> + dwmac->is_tx_retime_src_clk_125 = true;
>> +
>> + }
>
> That empty line is superfluous, please delete it.
>
>
Thanks,
srini
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
