On 01/18/18 13:36, Smitha T Murthy wrote: > On Fri, 2017-12-08 at 14:25 +0100, Philippe Ombredanne wrote: >> Smitha, >> >> On Fri, Dec 8, 2017 at 10:08 AM, Smitha T Murthy <smitha.t@xxxxxxxxxxx> wrote: >>> Adding the support for MFC v10.10, with new register file and >>> necessary hw control, decoder, encoder and structural changes. >>> >>> CC: Rob Herring <robh+dt@xxxxxxxxxx> >>> CC: devicetree@xxxxxxxxxxxxxxx >>> Signed-off-by: Smitha T Murthy <smitha.t@xxxxxxxxxxx> >>> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx> >>> Acked-by: Rob Herring <robh@xxxxxxxxxx> >> [] >>> --- /dev/null >>> +++ b/drivers/media/platform/s5p-mfc/regs-mfc-v10.h >>> @@ -0,0 +1,36 @@ >>> +/* >>> + * Register definition file for Samsung MFC V10.x Interface (FIMV) driver >>> + * >>> + * Copyright (c) 2017 Samsung Electronics Co., Ltd. >>> + * http://www.samsung.com/ >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License version 2 as >>> + * published by the Free Software Foundation. >>> + */ >> >> Have you considered using the new SPDX ids instead of this fine legalese? e.g.: >> >> // SPDX-License-Identifier: GPL-2.0 >> >> This is much shorter and neater (unless you are a legalese lover of >> course!) Check also Thomas doc patches and Linus comments on why he >> prefers the C++ comment style for these. >> >> And even better could be this more compact form? I am a big fan of the >> C++ style comments for these (and so is Linus) >> >> // SPDX-License-Identifier: GPL-2.0 >> // Copyright (c) 2017 Samsung Electronics Co., Ltd. >> // Register definition file for Samsung MFC V10.x Interface (FIMV) driver >> >> You can also read this fine article from a fellow Samsung colleague >> [1]. And if you ever consider doing this for all Samsung's past, >> present and future contributions, you will have my deep gratitude >> >> [1] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/ >> > Ok I will change to the SPDX license in the next patch series for the > v10 register file. Correspondingly for the MFC driver's files I will > update the license as a separate patch and submit. > Ah, I forgot about this series. I'll try to review it tomorrow or Monday. Sorry about the delay, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
