On Mon, Jan 15, 2018 at 05:57:05PM -0800, Hyun Kwon wrote: > +static struct drm_driver xlnx_drm_driver = { > + .driver_features = DRIVER_MODESET | DRIVER_GEM | > + DRIVER_ATOMIC | DRIVER_PRIME, > + .lastclose = xlnx_lastclose, > + > + .enable_vblank = xlnx_enable_vblank, > + .disable_vblank = xlnx_disable_vblank, I thought I've mentioned this already: Please don't use these hooks, they're deprecated. Instead use the ones in drm_crtc_funcs (that should also reduce the need for a bit of casting and indirection you have going on). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html