Hi Simon, On Sat, Jan 13, 2018 at 01:04:56PM +1100, Simon Shields wrote: > The MMS114 platform data has no in-tree users, so drop it, > and make the driver depend on CONFIG_OF. > > Switch to using the standard touchscreen properties via > touchscreen_parse_properties(), and move the old DT parsing code > to use device_property_*() APIs. > > Finally, use touchscreen_report_pos to report x/y coordinates > and drop the custom x/y inversion code. > > Signed-off-by: Simon Shields <simon@xxxxxxxxxxxxx> > --- > .../bindings/input/touchscreen/mms114.txt | 29 ++-- > drivers/input/touchscreen/Kconfig | 1 + > drivers/input/touchscreen/mms114.c | 152 +++++++++------------ > include/linux/platform_data/mms114.h | 24 ---- > 4 files changed, 83 insertions(+), 123 deletions(-) > delete mode 100644 include/linux/platform_data/mms114.h > The patch looks good, but you would also need to update the dtsi files in this same patch: ./arch/arm/boot/dts/exynos4412-trats2.dts ./arch/arm/boot/dts/exynos4210-trats.dts and Cc the Samsung-soc mailing list. For now it's a nack because the touchscreen would not work anymore with the trats boards. One more thing, you forgot Rob's ACK. Andi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
