> > > +/* > > > + * DO NOT change the device Ids. The naming is intentionally specific as both > > > + * the PMIC and CODEC parts of this chip are instantiated separately as I2C > > > + * devices (both have configurable I2C addresses, and are to all intents and > > > + * purposes separate). As a result there are specific DA9055 ids for PMIC > > > + * and CODEC, which must be different to operate together. > > > + */ > > > I'm not sure this comment is required. > > They are, we've already had the suffixes removed from both PMIC and > CODEC drivers by people doing code review causing the drivers to fail to > load for several kernel releases (this should be tagged to stable as a > result). > > > Most device IDs are named this way. > > Having the suffix on a subdevice would be normal but it's not normal for > the primary I2C device, usually you can just put the part number in. Okay, no problem then. Ignore my last. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
