1;5002;0c On Thu, Jan 11, 2018 at 09:21:06PM +0800, Icenowy Zheng wrote: > > > 于 2018年1月11日 GMT+08:00 下午7:48:40, Andre Przywara <andre.przywara@xxxxxxx> 写到: > >Hi, > > > >another take to avoid this patch at all, I just remembered this from an > >IRC discussion before: > > > >On 06/01/18 04:23, Icenowy Zheng wrote: > >> The Allwinner H6 pin controllers (both the main one and the CPUs one) > >> have no bus gate clocks. > > > >I don't think this is true. The pin controller *needs* an APB clock, > >it's just not gate-able or not exposed or documented. > >The "system bus tree" on page 90 in the manual shows that the "GPIO" > >block is located on the APB1 bus. > >So can't we just reference this apb clock directly? That would be much > >cleaner, "more" correct and require less changes: "The best patch is no > >patch": > > I can accept this. (In fact I have considered this, but > I don't dare to directly use bus clock in a device, as it's not > exported before. > > Maxime, Chen-Yu, can you agree the following code? Yes, that works for me. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
