On 2018년 01월 09일 20:56, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: >> In the mainline, there is no case to support the suspend-to-RAM for Samsung >> Exynos SoC. This patchset support the suspend-to-RAM for 64bit Exynos SoC. >> >> For 32bit, arch/arm/mach-exynos/* directoy contains the suspend-related >> codes such as suspend.c/exynos.c. But, 64bit Exynos should contain >> the suspend-related codes in the drivers/soc/samsung/*. So, this patchset >> develop the patch4/5 for drivers/soc/samsung/exynos-pm.c. to support suspend >> 64bit Exynos SoC. >> >> But, I'm not sure what is proper approach for both 32/64bit Exynos. >> - Approach1 : Split out the supend-related codes between 32/64bit. >> : arch/arm/mach-exynos/* contains the suspend-related codes for 32bit. >> : drivers/soc/samsung/* contains the suspend-related codes for 64bit. >> - Approach2 : Consolidate the all suspend-related codes to drivers/soc/samsung/. > > I prefer approach #2 - consolidate the code... unless this creates > some unmaintainable monster :) I'll try to consolidate code. [snip] -- Best Regards, Chanwoo Choi Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html