Best Regards! Anson Huang > -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: 2018-01-09 5:27 PM > To: Anson Huang <anson.huang@xxxxxxx> > Cc: Horia Geantă <horia.geanta@xxxxxxx>; Aymen Sghaier > <aymen.sghaier@xxxxxxx>; Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; > David S. Miller <davem@xxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > Mark Rutland <mark.rutland@xxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; > Sascha Hauer <kernel@xxxxxxxxxxxxxx>; Fabio Estevam > <fabio.estevam@xxxxxxx>; Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>; > Michael Turquette <mturquette@xxxxxxxxxxxx>; Stephen Boyd > <sboyd@xxxxxxxxxxxxxx>; Adriana Reus <adriana.reus@xxxxxxx>; Stefan > Agner <stefan@xxxxxxxx>; Dong Aisheng <dongas86@xxxxxxxxx>; open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > <devicetree@xxxxxxxxxxxxxxx>; linux-clk@xxxxxxxxxxxxxxx; linux- > crypto@xxxxxxxxxxxxxxx; moderated list:ARM/FREESCALE IMX / MXC ARM > ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel <linux- > kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock > > Hi Anson, > > On Tue, Jan 9, 2018 at 12:51 AM, Anson Huang <Anson.Huang@xxxxxxx> > wrote: > > > + - clocks > > + Usage: required if SNVS LP RTC requires explicit enablement of clocks > > + Value type: <prop_encoded-array> > > + Definition: A list of phandle and clock specifier pairs describing > > + the clocks required for enabling and disabling SNVS LP RTC. > > > It is a single clock that is used here, so it would be better to describe the text as: > > Definition: A clock specifier describing the clock required for enabling and > disabling SNVS LP RTC > > > + - clock-names > > + Usage: required if SNVS LP RTC requires explicit enablement of clocks > > + Value type: <string> > > + Definition: A list of clock name strings in the same order as the > > + clocks property. > > and here you must describe that the name should be "snvs-rtc": > > Definition: Clock name string should be "snvs-rtc". Agree, thanks. Will resend the patch. Anson. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
