Re: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Fabrizio,

Happy to see that this patch series is of interest ;)

As you can see in mail thread, Maxime Ripard is also testing it:
https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg124322.html

For BT656 support, it was not initially planned but it seems 
straightforward to code it, and anyway I have to add JPEG support, so I 
could add BT656 support in next patch series.

For your symptom, I would say same as I said to Maxime, check first the 
polarity of sync signals (hysnc/vysnc/pclk) between ISP and OV5640.
Note also that several frames are needed to get a non-black picture.
You can also use the colorbar test to validate bus connection between 
ISP and sensor.

Here are the yavta commands that I'm commonly using:

* grab QVGA RGB565 raw frame (note the skip=10 to get a correct image)
yavta -s 320x240 -n 3 --capture=13 --skip=10 --format=RGB565 /dev/video0 
--file=grab-320x240-rgb565-#.raw

* grab QVGA YUV frame
yavta -s 320x240 -n 3 --capture=13 --skip=10 --format=YUYV /dev/video0 
--file=grab-320x240-yuyv-#.raw

* grab QVGA colorbar RGB565 raw frame
yavta -s 320x240 -n 3 -w '0x009f0903 1' --capture=1 --format=RGB565 
/dev/video0 --file=grab-colorbar-320x240-rgb565-#.raw

* disable colorbars
yavta -s 320x240 -n 3 -w '0x009f0903 0' /dev/video0


Hope this will help !

Best regards,
Hugues.

On 01/08/2018 09:54 PM, Fabrizio Castro wrote:
> Hello Hugues,
> 
> thank you for the patch series.
> I am having a go with your patches, and although they seem alright, I don't seem to be able to grab a non-black picture on the iWave iwg20d in plain DVP mode, but if I switch to BT656 just by setting register 0x4730 to 0x01 (I know, it's a nasty hack...) I can get something sensible out.
> 
> At the moment there is no proper BT656 support in the driver, I was wondering if you have any plans to enhance the ov5640 driver a little bit further to add proper BT656 support as it may be convenient.
> 
> Do you know if someone else was able to get DVP to work by means of this patch series on a non-STM32 platform?
> 
> Thanks,
> Fabrizio
> 
> 
>> Subject: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support
>>
>> Enhance OV5640 CSI driver to support also DVP parallel interface.
>> Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing
>> YUV422 UYVY format.
>> Some other improvements on chip identifier check and removal
>> of warnings in powering phase around gpio handling.
>>
>> ===========
>> = history =
>> ===========
>> version 5:
>>    - Refine bindings as per Sakari suggestion:
>>      https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg124048.html
>>
>> version 4:
>>    - Refine bindings as per Sakari suggestion:
>>      https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg123609.html
>>    - Parallel port control lines polarity can now be configured through
>>      devicetree
>>
>> version 3:
>>    - Move chip identifier check at probe according to Fabio Estevam comment:
>>      https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg122575.html
>>    - Use 16 bits register read for this check as per Steve Longerbeam comment:
>>      https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg122692.html
>>    - Update bindings to document parallel mode support as per Fabio Estevam comment:
>>      https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg122576.html
>>    - Enable the whole 10 bits parallel output and document 8/10 bits support
>>      in ov5640_set_stream_dvp() to answer to Steve Longerbeam comment:
>>      https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg122693.html
>>
>> version 2:
>>    - Fix comments from Sakari Ailus:
>>      https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg122259.html
>>    - Revisit ov5640_set_stream_dvp() to only configure DVP at streamon
>>    - Revisit ov5640_set_stream_dvp() implementation with fewer register settings
>>
>> version 1:
>>    - Initial submission
>>
>> Hugues Fruchet (5):
>>    media: ov5640: switch to gpiod_set_value_cansleep()
>>    media: ov5640: check chip id
>>    media: dt-bindings: ov5640: refine CSI-2 and add parallel interface
>>    media: ov5640: add support of DVP parallel interface
>>    media: ov5640: add support of RGB565 and YUYV formats
>>
>>   .../devicetree/bindings/media/i2c/ov5640.txt       |  46 ++-
>>   drivers/media/i2c/ov5640.c                         | 325 ++++++++++++++++++---
>>   2 files changed, 324 insertions(+), 47 deletions(-)
>>
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
> ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux