Best Regards! Anson Huang > -----Original Message----- > From: Dong Aisheng [mailto:dongas86@xxxxxxxxx] > Sent: 2018-01-09 10:17 AM > To: Anson Huang <anson.huang@xxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; dl-linux-imx <linux- > imx@xxxxxxx>; shawnguo@xxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Fabio > Estevam <fabio.estevam@xxxxxxx>; mturquette@xxxxxxxxxxxx; > sboyd@xxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; > stefan@xxxxxxxx; linux@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] ARM: dts: imx7s: add snvs rtc clock > > On Tue, Jan 09, 2018 at 01:43:25AM +0000, Anson Huang wrote: > > > > > > Best Regards! > > Anson Huang > > > > > > > -----Original Message----- > > > From: Dong Aisheng [mailto:dongas86@xxxxxxxxx] > > > Sent: 2018-01-08 6:39 PM > > > To: Anson Huang <anson.huang@xxxxxxx> > > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; > > > linux- kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > > dl-linux-imx <linux- imx@xxxxxxx>; shawnguo@xxxxxxxxxx; > > > kernel@xxxxxxxxxxxxxx; Fabio Estevam <fabio.estevam@xxxxxxx>; > > > mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > > > mark.rutland@xxxxxxx; stefan@xxxxxxxx; linux@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH 2/2] ARM: dts: imx7s: add snvs rtc clock > > > > > > On Thu, Jan 04, 2018 at 11:06:42PM +0800, Anson Huang wrote: > > > > Add i.MX7 SNVS RTC clock. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > > > > > If this clock IMX7D_SNVS_CLK is used for all SNVS sub modules, then > > > snvs_poweroff and snvs_pwrkey should also rely on it, right? > > > > > > How about add them all in one time? > > > > > > BTW, syscon-poweroff seems still not introduce clock support and > > > fsl,sec-v4.0- pwrkey also does not handle clock, they may need to be added > later. > > > > > > Regards > > > Dong Aisheng > > > > Yes, I thought about it before sending patch, but currently the > > poweroff and pwrkey driver do NOT handle clocks, so I plan to add them later, > including handling clocks in driver and dtb. > > > > SNVS RTC binding doc does not claim a optional clock support, you probably > may need update the binding doc as well. > > BTW, Should mx6 platforms need the same fixes? > If yes, we'd better fix them all. I.MX6 platforms has no such SNVS CCGR clock gate, no need to change. OK, I will update the SNVS RTC binding doc and send out a V2 patch set. Anson. > > Regards > Dong Aisheng > > > Anson > > > > > > > > > --- > > > > arch/arm/boot/dts/imx7s.dtsi | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/imx7s.dtsi > > > > b/arch/arm/boot/dts/imx7s.dtsi index e718fd2..f9b97f3 100644 > > > > --- a/arch/arm/boot/dts/imx7s.dtsi > > > > +++ b/arch/arm/boot/dts/imx7s.dtsi > > > > @@ -534,6 +534,8 @@ > > > > offset = <0x34>; > > > > interrupts = <GIC_SPI 19 > > > IRQ_TYPE_LEVEL_HIGH>, > > > > <GIC_SPI 20 > > > IRQ_TYPE_LEVEL_HIGH>; > > > > + clocks = <&clks IMX7D_SNVS_CLK>; > > > > + clock-names = "snvs-rtc"; > > > > }; > > > > > > > > snvs_poweroff: snvs-poweroff { > > > > -- > > > > 1.9.1 > > > > > > > > -- > > > > To unsubscribe from this list: send the line "unsubscribe linux-clk" > > > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More > > > > majordomo info at > > > > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2F > > > > vger > > > > .kernel.org%2Fmajordomo- > > > info.html&data=02%7C01%7CAnson.Huang%40nxp.com > > > > %7Cd10ff23b822b4cd16c2708d5568417c6%7C686ea1d3bc2b4c6fa92cd99c5 > c30 > > > 1635 > > > > %7C0%7C0%7C636510047707248763&sdata=FMx22hfKxs7YA%2F1zCVeYC > nVX > > > 9Ck4MmB9 > > > > GuolA51V2eg%3D&reserved=0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
