Re: [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander

[Phil Elwell <phil@xxxxxxxxxxxxxxx>]

Hi Stefan,

On 03/01/2018 20:17, Stefan Wahren wrote:
> Hi Baruch,
>
> > Stefan Wahren <stefan.wahren@xxxxxxxx> hat am 2. Januar 2018 um 20:03 geschrieben:
> >
> >
> > Hi Baruch,
> >
> > > Baruch Siach <baruch@xxxxxxxxxx> hat am 2. Januar 2018 um 14:19 geschrieben:
> >
> > > +		expgpio: expgpio {
> > > +			compatible = "brcm,bcm2835-expgpio";
> > > +			gpio-controller;
> > > +			#gpio-cells = <2>;
> > > +			firmware = <&firmware>;
> >
> > Please add the gpio-line-names from Eric's patch [1].
> >
> > Thanks
> > Stefan
> >
> > [1] - https://patchwork.kernel.org/patch/9339857/
>
> sorry i missed the fact that the same GPIO expander is on the CM3. So please move the exgpio node to bcm2837.dtsi and only define the gpio-line-names in this file.

The GPIO expander is not a part of the BCM2837 SoC, and not all BCM2837-based Pis have a GPIO expander - see the Pi 2+.

Phil
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html