On Wed 03 Jan 08:27 PST 2018, Srinivas Kandagatla wrote: > Thanks for the comments, > > On 03/01/18 00:22, Bjorn Andersson wrote: > > On Thu 14 Dec 09:34 PST 2017, srinivas.kandagatla@xxxxxxxxxx wrote: > > > > > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> [..] > > > + lpass_q6_smmu: arm,smmu-lpass_q6@1600000 { > > > > name this node "iommu" > will rename it to arm,smmu@1600000 > I don't think you're supposed to have , in the node names, and whenever possible they should be generic names of the function. So analog to "clock-controller", "dma-controller", "serial", "i2c" etc I believe this should be "iommu". Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html