Hi, On 09/23/2013 04:59 PM, Roger Quadros wrote: > On 09/23/2013 03:59 PM, Sergei Shtylyov wrote: >> Hello. >> >> On 23-09-2013 11:37, Roger Quadros wrote: >> >>>>> Not sure why you asked -- I'm not using this driver, neither I'm >> >>>> Well, you have better grip of what's going on in the embedded world >>>> than me. I'm mostly curious whether adding dependency on PHY is okay. >> >>> There is no hard dependency on presence of PHY. The driver will continue >>> as usual if devm_phy_get() fails. >>> I hope selecting GENERIC_PHY in Kconfig is not an issue. >> >> Selecting in the AHCI_PLATFORM section? It seems I have overlooked it. No, I don't think it's a good idea. The generic PHY functions seem to be stubbed when GENERIC_PHY=n. >> > OK I will remove the select then. If I remove the select then build fails like so if we set CONFIG_GENERIC_PHY to 'm' and CONFIG_SATA_AHCI_PLATFORM to 'y' drivers/built-in.o: In function `ahci_platform_enable_resources': (.text+0x162647): undefined reference to `phy_init' drivers/built-in.o: In function `ahci_platform_enable_resources': (.text+0x16267c): undefined reference to `phy_power_on' drivers/built-in.o: In function `ahci_platform_enable_resources': (.text+0x162694): undefined reference to `phy_exit' drivers/built-in.o: In function `ahci_platform_disable_resources': (.text+0x1626af): undefined reference to `phy_power_off' drivers/built-in.o: In function `ahci_platform_disable_resources': (.text+0x1626b7): undefined reference to `phy_exit' drivers/built-in.o: In function `ahci_platform_get_resources': (.text+0x162768): undefined reference to `devm_phy_get' make: *** [vmlinux] Error 1 This means we need to make CONFIG_SATA_AHCI_PLATFORM depend on CONFIG_GENERIC_PHY or select it. OR Generic PHY layer must be fixed so that the API's are always built in. What is the better option? I believe making the PHY API's always built in is the better option. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html