On Wed, Dec 27, 2017 at 09:01:47PM +0100, Pavel Machek wrote: > Hi! > > > > +Required properties: > > > +- compatible: "avago,apds990x" > > > +- reg: address on the I2C bus > > > +- interrupts: external interrupt line number > > > +- Vdd-supply: power supply for VDD > > > +- Vled-supply: power supply for LEDA > > > > AFAIK the custom is to use lower case letters for regulator supplies. > > > > > +- ga: Glass attenuation > > > +- cf1: Clear channel factor 1 > > > +- irf1: IR channel factor 1 > > > +- cf2: Clear channel factor 2 > > > +- irf2: IR channel factor 2 > > > +- df: Device factor > > > +- pdrive: IR current, one of APDS_IRLED_CURR_XXXmA values > > > +- ppcount: Proximity pulse count > > > > Are these device specific? If so, please add the vendor prefix to them. > > Well, whole binding is "vendor specific". Does it make sense to add > prefix in such case? Yes, it does. If you later find one or more of these are generic, you could remove the vendor prefix. I doubt that'll happen though, these seem very device specific parameters. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
