On 23 December 2017 at 18:13, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: > Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> writes: > >>> What I would propose instead is : >>> - keep both the new marvell nand driver and the old pxa3xx_nand driver >>> - switch pxa_defconfig to compile them both >> >> Didn't notice you were suggesting to compile both, which doesn't work >> because both drivers match the same devices, and only one of them >> can actually claim the device (likely the first one to register to the >> device model). So, to make it safe you need to have a >> >> depends on !MTD_NAND_PXA3xx >> >> in your MTD_NAND_MARVELL entry, which means only one driver can be >> compiled. > Mmm... that is I didn't explain to you what pxa_defconfig is designed for. > This defconfig is not for any board actually, it rather is a build coverage > tool. > >> So let's find a way to fix the remaining issues you have instead of delaying >> the inevitable. > It's up to you of course, as long as my boards don't break, and nothing breaking > them is merged, I'm fine with it. It's just not the approach I usually choose, > I'm rather a 2-step guy, ie. merge the new one, then merge the switch (which can > be reverted easilly). > I agree with Boris on this. Let's get this new driver tested as much as possible; then, once everyone is fairly happy with it, merge it. It won't be completely stable on day-one, but that is why we have -rc cycles. Plus, distributions and appliances use -stable. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
