On Mon, Nov 27, 2017 at 3:19 AM, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > ARCH_S3C24XX is a very exceptional platform that some DT files in > arch/arm/boot/dts/, but does not select USE_OF. Not entirely. The platform does select USE_OF - when MACH_S3C2416_DT is chosen. For other boards USE_OF is not necessary because they do not use DT. Why you need to select it for entire arch? Best regards, Krzysztof > > All the other platforms with DT files correctly select USE_OF > directly or indirectly (Most of them are either ARCH_MULTIPLATFORM > or ARM_SINGLE_ARMV7M). > > With ARCH_S3C24XX fixed, "ifeq ($(CONFIG_OF),y)" in DT Makefile > can be deleted. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > --- > > arch/arm/Kconfig | 1 + > arch/arm/boot/dts/Makefile | 3 --- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 51c8df5..5604497 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -595,6 +595,7 @@ config ARCH_S3C24XX > select MULTI_IRQ_HANDLER > select NEED_MACH_IO_H > select SAMSUNG_ATAGS > + select USE_OF > help > Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443 > and S3C2450 SoCs based systems, such as the Simtec Electronics BAST > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index d0381e9..6f7f25d 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1,6 +1,4 @@ > # SPDX-License-Identifier: GPL-2.0 > -ifeq ($(CONFIG_OF),y) > - > dtb-$(CONFIG_ARCH_ALPINE) += \ > alpine-db.dtb > dtb-$(CONFIG_MACH_ARTPEC6) += \ > @@ -1104,4 +1102,3 @@ dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb > dtb-$(CONFIG_ARCH_ASPEED) += aspeed-bmc-opp-palmetto.dtb \ > aspeed-bmc-opp-romulus.dtb \ > aspeed-ast2500-evb.dtb > -endif > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
