+ Philippe On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote: > >> I'll change it for v3 of this patch however it will end up like this: > >> //SPDX-License... > > > > That should be /* SPDX-License */, // is for c files. > > Got any reference for that? Since we're using the C preprocessor before > feeding them to dtc, we can use the same // style for both, builds fine. > > Only for my private DT overlay files that I use directly with dtc I > couldn't adopt that style. > The doc states: If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/\* \*/" style comment in C header files. I interpreted that as dtc doesn't handle // comments, use /**/ But I agree it also states: .dts{i}: // SPDX-License-Identifier: <SPDX License Expression> So I think we will end up with a mix of both. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html