The present change is a bug fix for AVB link iteratively up/down. Steps to reproduce: - start AVB TX stream (Using aplay via MSE), - disconnect+reconnect the eth cable, - after a reconnection the eth connection goes iteratively up/down without user interaction, - this may heal after some seconds or even stay for minutes. As the documentation specifies, the "renesas,no-ether-link" option should be used when a board does not provide a proper AVB_LINK signal. There is no need for this option enabled on RCAR H3/M3 Salvator-X/XS and ULCB starter kits since the AVB_LINK is correctly handled by HW. Choosing to keep or remove the "renesas,no-ether-link" option will have impact on the code flow in the following ways: - keeping this option enabled may lead to unexpected behavior since the RX & TX are enabled/disabled directly from adjust_link function without any HW interrogation, - removing this option, the RX & TX will only be enabled/disabled after HW interrogation. The HW check is made through the LMON pin in PSR register which specifies AVB_LINK signal value (0 - at low level; 1 - at high level). In conclusion, the change is also a safety improvement because it removes the "renesas,no-ether-link" option leading to a proper way of detecting the link state based on HW interrogation and not on software heuristic. Note that DTS files for V3M Starter Kit, Draak and Eagle boards contain the same property, the files are untouched due to unavailable schematics to verify if the fix applies to these boards as well. Changes from v1 to v2: * per a request from Simon added Fixes tags to both changes, the specified commits generalize Salvator-X and ULCB dtsi files and the fixes should be applicable without a conflict, however similar but virtually different fixes can be spread into Salvator-X and ULCB board DTS files of older kernel revisions as well. Bogdan Mirea (2): arm64: dts: renesas: salvator-x: Remove renesas,no-ether-link property arm64: dts: renesas: ulcb: Remove renesas,no-ether-link property arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 - arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 - 2 files changed, 2 deletions(-) -- 2.8.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
