On Thu, Dec 21, 2017 at 4:18 PM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > 2017-12-21 15:08 GMT+01:00 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: >> On Thu, Dec 21, 2017 at 3:48 PM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: >>> "atmel,spd" is reported by checkpatch as undocumented in the device >>> tree bindings. Add it to the list of supported compatible strings. >> >>> "atmel,24c00", >>> "atmel,24c01", >>> "atmel,24c02", >>> + "atmel,spd", >>> "atmel,24c04", >>> "atmel,24c08", >>> "atmel,24c16", >> >> Sounds alogical to me to make a split by this new record. >> Can you find better line to inject? > They are actually ordered by memory size. I want to keep it like this > in the driver and I prefer that the DT reflect it. So, I just disagree on the above. Rationale I described at one of the comment. At the end it's your call, but from my p.o.v. it makes life harder to read and catch the chips which are (un)supported. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
