On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote: > On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote: > > Add a label property to identify the edge this node represents. > > Why does a user need to know this? > We have multiple remoteproc instances, each one having one or more associated SMD or GLINK links (this node), exposing logical communication channels. Some of these logical channels are exposed to user space and we need a way to distinguish them there. In the current implementation of SMD this value goes straight into an sysfs attribute that we can use when writing udev rules and for the DIAG implementation to pair up channels related to the same remoteproc. This adds the equivalent information for glink-backed channels. I'm therefor in favor of picking this patch. Regards, Bjorn > > > > Signed-off-by: Chris Lew <clew@xxxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt > > index 9663cab52246..0b8cc533ca83 100644 > > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt > > @@ -10,6 +10,11 @@ edge. > > Value type: <stringlist> > > Definition: must be "qcom,glink-rpm" > > > > +- label: > > + Usage: optional > > + Value type: <string> > > + Definition: should specify the subsystem name this edge corresponds to. > > + > > - interrupts: > > Usage: required > > Value type: <prop-encoded-array> > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
