2017-12-20 17:58 GMT+08:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>: > On Wed, Dec 20, 2017 at 10:54 AM, kbuild test robot <lkp@xxxxxxxxx> wrote: >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on tip/timers/core] >> [cannot apply to linus/master v4.15-rc4 next-20171220] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> >> url: https://github.com/0day-ci/linux/commits/Greentime-Hu/Andes-nds32-Linux-Kernel/20171220-155937 >> config: sparc64-allyesconfig (attached as .config) >> compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 >> reproduce: >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # save the attached .config to linux build tree >> make.cross ARCH=sparc64 >> >> All warnings (new ones prefixed by >>): >> >> drivers/net/ethernet/faraday/ftmac100.c: In function 'ftmac100_rxdes_set_page': >>>> drivers/net/ethernet/faraday/ftmac100.c:288:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >> rxdes->rxdes3 = (unsigned int)page; >> ^ > > The proper way to casts pointer to integers is to cast to "uintptr_t". > > However, the address is stored in a 32-bit descriptor, which means it can > not work on 64-bit platforms. > > Please make the driver depend on "!64BIT || BROKEN" > > Cfr. commit 15bfe05c8d6386f1 ("net: ethernet: xilinx: Mark XILINX_LL_TEMAC > broken on 64-bit") > Thanks Geert. I will apply it like this. +++ b/drivers/net/ethernet/faraday/Kconfig @@ -5,7 +5,7 @@ config NET_VENDOR_FARADAY bool "Faraday devices" default y - depends on ARM + depends on ARM || NDS32 || COMPILE_TEST ---help--- If you have a network (Ethernet) card belonging to this class, say Y. @@ -18,7 +18,8 @@ if NET_VENDOR_FARADAY config FTMAC100 tristate "Faraday FTMAC100 10/100 Ethernet support" - depends on ARM + depends on ARM || NDS32 || COMPILE_TEST + depends on !64BIT || BROKEN select MII ---help--- This driver supports the FTMAC100 10/100 Ethernet controller @@ -27,7 +28,8 @@ config FTMAC100 config FTGMAC100 tristate "Faraday FTGMAC100 Gigabit Ethernet support" - depends on ARM + depends on ARM || NDS32 || COMPILE_TEST + depends on !64BIT || BROKEN select PHYLIB ---help--- This driver supports the FTGMAC100 Gigabit Ethernet controller -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
