On Thu, Feb 06, 2014 at 04:39:25PM +0000, Ian Campbell wrote: > On Thu, 2014-02-06 at 10:39 -0500, Jason Cooper wrote: > > > > > + pmx_fan_33: pmx-fan-33 { > > > + marvell,pins = "mpp33"; > > > + marvell,function = "gpo"; > > > + }; > > Typo I think. Hi Ian drivers/pinctrl/mvebu/pinctrl-kirkwood.c: MPP_MODE(33, MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(0, 1, 1, 1, 1, 0)), MPP_VAR_FUNCTION(0x2, "tdm", "dtx", V(0, 0, 1, 1, 1, 0)), MPP_VAR_FUNCTION(0x3, "ge1", "txctl", V(0, 1, 1, 1, 1, 0)), MPP_VAR_FUNCTION(0xb, "lcd", "d13", V(0, 0, 0, 0, 1, 0))), MPP_MODE(34, It is output only. I actually had the opposite bug in v1, setup two gpo's as gpio's. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html