Hi Rob, On 06/02/14 14:33, Rob Herring wrote: > On Fri, Jan 17, 2014 at 7:58 AM, James Hogan <james.hogan@xxxxxxxxxx> wrote: >> +Required properties: >> +- compatible: Should be "img,ir1" > > Kind of short for a name. I don't have anything much better, but how > about img,ir-rev1. Okay, that sounds reasonable. >> +Optional properties: >> +- clocks: List of clock specifiers as described in standard >> + clock bindings. >> +- clock-names: List of clock names corresponding to the clocks >> + specified in the clocks property. >> + Accepted clock names are: >> + "core": Core clock (defaults to 32.768KHz if omitted). >> + "sys": System side (fast) clock. >> + "mod": Power modulation clock. > > You need to define the order of clocks including how they are > interpreted with different number of clocks (not relying on the name). Would it be sufficient to specify that "clock-names" is required if "clocks" is provided (i.e. unnamed clocks aren't used), or is there some other reason that clock-names shouldn't be relied upon? Thanks for reviewing, Cheers James > Although, if the h/w block really has different number of clock > inputs, then it is a different h/w block and should have a different > compatible string.
Attachment:
signature.asc
Description: OpenPGP digital signature
