Hi Simon, > > > #ifdef CONFIG_OF > > > static const struct of_device_id mms114_dt_match[] = { > > > - { .compatible = "melfas,mms114" }, > > > + { > > > + .compatible = "melfas,mms114", > > > + .data = (void *)TYPE_MMS114, > > > + }, { > > > + .compatible = "melfas,mms152", > > > + .data = (void *)TYPE_MMS152, > > > > You are not documenting the new "melfas,mms152" compatible in > > Documentation/devicetree/bindings/input/touchscreen/mms114.txt > > Yes I am - "melfas,mms152" is added to the documentation > as part of this patch. Is there something wrong with what I've done > there? Oh yes, sorry! I missed it while snipping the code :) Please ignore this comment, then. Andi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html