On Sat, Dec 16, 2017 at 11:32 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> Hi Tim,
>
> On Thu, Nov 9, 2017 at 4:45 PM, Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote:
>
>> +static int tda1997x_set_power(struct tda1997x_state *state, bool on)
>> +{
>> + int ret = 0;
>> +
>> + if (on) {
>> + ret = regulator_bulk_enable(TDA1997X_NUM_SUPPLIES,
>> + state->supplies);
>> + msleep(300);
>
> Didn't you miss a 'return ret' here?
>
> Otherwise regulator_bulk_disable() will always be called below.
>
Fabio,
Yes thanks for catching that. I'll fix in the next revision.
Tim
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
