Rafael, On 12/16/2017 04:52 AM, Rafael J. Wysocki wrote: > On Fri, Dec 15, 2017 at 3:29 PM, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: >> On Fri, Dec 15, 2017 at 5:25 AM, Dave Gerlach <d-gerlach@xxxxxx> wrote: >>> Document the devicetree bindings that describe Texas Instruments >>> opp-supply which allow a platform to describe multiple regulators and >>> additional information, such as registers containing data needed to >>> program aforementioned regulators. >>> >>> Signed-off-by: Dave Gerlach <d-gerlach@xxxxxx> >> >> I need an ACK from Rob on this one. > > Actually, how this (and the next patch) is related to the [1-2/4]? > The main goal of this series is to add support for scaling the multiple regulators needed for the CPU on these TI platforms. The OPP core supports multiple regulators but only to the point that it can associate a list of regulators to a device. It still by default only scales the normal vdd regulator when doing a rate transition. Because of this, we must define our own method of doing rate transitions to take the references to our regulators held in the OPP core and scale them in the proper sequence depending on what the platform needs. So to describe the purpose of each patch and their relation to each other: Patch 1: We must be able to defer the ti-cpufreq driver now that we look for regulators during probe as they likely won't be ready when we probe. Patch 2: Tell the OPP core about regulators needed for TI CPUFreq operation using the OPP core. This doesn't actually do anything besides place them in a list at this point because the OPP core can't know how TI platforms needs them scaled in relation to each other. Placing the regulator definition in ti-cpufreq driver ensures they are registered with opp core before cpufreq-dt probes (which is triggered at the end of ti-cpufreq probe) and actually makes the opp core get the regulators. Patch 3: Binding doc for patch 4 driver. Patch 4: TI OPP supply driver which understands how to actually make use of the two regulators that the OPP core now has a reference to. This overrides the standard opp_set_rate function to let us scale frequency and voltage as needed for TI platforms. Regards, Dave -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html