Hi Wenyou, Wenyou Yang wrote: ... > +static int ov7740_start_streaming(struct ov7740 *ov7740) > +{ > + int ret; > + > + if (ov7740->fmt) { > + ret = regmap_multi_reg_write(ov7740->regmap, > + ov7740->fmt->regs, > + ov7740->fmt->reg_num); > + if (ret) > + return ret; > + } > + > + if (ov7740->frmsize) { > + ret = regmap_multi_reg_write(ov7740->regmap, > + ov7740->frmsize->regs, > + ov7740->frmsize->reg_num); > + if (ret) > + return ret; > + } > + > + return __v4l2_ctrl_handler_setup(ov7740->subdev.ctrl_handler); I believe you're still setting the controls after starting streaming. -- Sakari Ailus sakari.ailus@xxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html