Fabio, On Sun, Dec 17, 2017 at 10:59 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: > Hi Stefan, > > On Sun, Dec 17, 2017 at 6:37 PM, Stefan Agner <stefan@xxxxxxxx> wrote: > >> --- /dev/null >> +++ b/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts >> @@ -0,0 +1,20 @@ >> +/* >> + * Copyright 2017 Toradex AG >> + * >> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + */ > > In the previous patch you used GPL-2.0 text, instead of GPL-2.0+. > > The SPDX line should be the first one and start with a // style comment: > > // SPDX-License-Identifier: (GPL-2.0 OR MIT) Yes this line as the top line is the correct way as explained in Thomas doc patches [1] I cannot comment of whether the author wants GPL 2 or 2+ though KISS is best. [1] https://lkml.org/lkml/2017/12/4/934 > Philippe, please confirm this is the correct way. > > With this fixed you can add: > > Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx> -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
