Re: [PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Dec 15, 2017 at 12:51:36AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> In the provided example the unit address does not match the 'reg' value.
> 
> Fix the unit address.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> index 02f45c6..19e1819 100644
> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> @@ -44,7 +44,7 @@ Example:
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  
> -			pgc_pcie_phy: power-domain@3 {
> +			pgc_pcie_phy: power-domain@IMX7_POWER_DOMAIN_PCIE_PHY {

That's ugly.

Defines in reg is not something we should use generally, IMO. There are 
a few exceptions for flags.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux