On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote: > Also, it was using whitespaces for indentation on some lines, fix that > while moving it. > > Signed-off-by: Damien Riegel <damien.riegel@xxxxxxxxxxxxxxxxxxxx> Rather than extending single nodes like this I would prefer that we bring in the associated pmic node, by this we avoid just having a huge flat list of nodes. I.e. that we make this: &pm8916_1 { codec@f000 { status = "okay"; clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>; clock-names = "mclk"; qcom,mbhc-vthreshold-low = <75 150 237 450 500>; qcom,mbhc-vthreshold-high = <75 150 237 450 500>; }; }; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html