Hi Krzysztof,
On 2017-12-14 09:48, Krzysztof Kozlowski wrote:
Hi Simon,
Thanks for new boards!
+Cc Marek, Bartlomiej,
On Tue, Dec 12, 2017 at 3:08 PM, Simon Shields <simon@xxxxxxxxxxxxx> wrote:
"midas" is the codename for a family of smartphones released by Samsung
Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy
Note 2 (GT-N7100/N7105). The boards largely have the same peripherals:
the main differences are touchscreen, display panel and cellular modem.
Signed-off-by: Simon Shields <simon@xxxxxxxxxxxxx>
---
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 144 +++
arch/arm/boot/dts/exynos4412-m0.dts | 14 +
arch/arm/boot/dts/exynos4412-m3.dts | 19 +
arch/arm/boot/dts/exynos4412-midas.dtsi | 1291 +++++++++++++++++++++++++++
M0 is essentially Trats2. You are duplicating here almost entire
Trats2 which means:
1. A lot of duplicated code thus it will require more maintenance to
keep DTS synced,
2. It is very difficult to spot the changes and possible errors
between Trats2 and Midas DTSI/M0.
Please make a generic family of devices based on Midas, including
Trats2. You might make it in steps for easier review:
1. Split common Trats2 part,
2. Add new boards.
Krzysztof is right. Trats2 should also be based on midas.dtsi (it is very
similar to gt-i9300, the difference in mainly in the casing). We also used
gt-i9300 with modified bootloader with Trats2 dts.
It should not be hard to adapt it for common midas.dtsi base (hind: use
scripts/dtc/dtx_diff for checking if the final dts is correct).
> ...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
