On Fri, Dec 8, 2017 at 2:41 PM, Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx> wrote: >> - pctl->desc = &axp20x_data; >> + pctl->desc = (struct axp20x_pctrl_desc *)of_device_get_match_data(dev); >> pctl->regmap = axp20x->regmap; >> pctl->dev = &pdev->dev; >> > > I am using pctl->desc before retrieving it, thus dereferencing from a > null pointer. > > We just have to move > pctl->chip.ngpio = pctl->desc->npins; > after > pctl->desc = (struct axp20x_pctrl_desc *)of_device_get_match_data(dev); > > Linus, I guess that I should send a patch to fix this or is there an > other way not to have to apply such a small and dumb patch? Just send a patch based on my pin control tree "devel" branch or linux-next, it's cool. Things like this happens all the time. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
