Hi Srinivas, Am Montag, den 03.02.2014, 14:27 +0000 schrieb srinivas.kandagatla@xxxxxx: > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> > > Hi All, > > This patch series adds reset controller support for STi SOC series STiH415 and > STiH416. It adds support for both power down reset and soft reset controllers. > On STi series SOCs reset lines are wired up to system configuration registers. > Most of the IPs on STi SOCs are left in reset state, so this driver is very > important for other drivers to use the IPs. > > Patch 01: Adds reset controller based on system configuration registers via > regmap. > > Patch 02, 03: adds STiH415 and STiH416 reset controller drivers. > > Patch 04, 05: adds STiH415 and STiH416 soft reset controllers. > > The final patch 06 selects reset controller in mach-sti Kconfig. > > I would like get this driver in to 3.15, so that its possible to add dt > support for other IPs with reset lines. Without this patchset its impossible > to add DT support to IPs with reset lines as reset line definition is in > common header file in include/dt-bindings/. > > This reset controller will be used by gmac, i2c and st-ir drivers. > > > Comments? the patchset looks good to me for the soft resets. But for the powerdown bits I am wondering whether the reset controller API is the right abstraction. Depending on whether those bits really just put the IPs into reset or there is some power gating / sequencing involved, shouldn't this rather be handled as a set of pm domains? I see that for example on STiH415 there are both soft resets and powerdown bits for USB[012]. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
