Brendan, On Thu, Dec 7, 2017 at 9:37 PM, Brendan Higgins <brendanhiggins@xxxxxxxxxx> wrote: > Any update on this? > > On Fri, Nov 17, 2017 at 11:07 AM, Brendan Higgins > <brendanhiggins@xxxxxxxxxx> wrote: >> Adds basic support for the Nuvoton NPCM750 BMC. >> >> Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> >> Reviewed-by: Tomer Maimon <tmaimon77@xxxxxxxxx> >> Reviewed-by: Avi Fishman <avifishman70@xxxxxxxxx> >> Tested-by: Tomer Maimon <tmaimon77@xxxxxxxxx> >> Tested-by: Avi Fishman <avifishman70@xxxxxxxxx> <snip> >> --- /dev/null >> +++ b/arch/arm/mach-npcm/npcm7xx.c >> @@ -0,0 +1,25 @@ >> +/* >> + * Copyright (c) 2017 Nuvoton Technology corporation. >> + * Copyright 2017 Google, Inc. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ Have you considered using the new SPDX ids here instead of the traditional license boilerplate? This could come out this way: // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2017 Nuvoton Technology corporation. // Copyright 2017 Google, Inc. It is shorter and simpler, with a better code/comments ratio. And if you wonder about why using C++ style comment, please check Linus posts on the topic, as well as Thomas doc patches. Thank you for your kind consideration! -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
