Hello, On Thu, Dec 07, 2017 at 05:26:50PM +0100, Bartosz Golaszewski wrote: > > + if (at24->chip.flags & AT24_FLAG_NO_RDROL) { > > + bits = (at24->chip.flags & AT24_FLAG_ADDR16) ? 16 : 8; > > There's no need for braces around the ternary operator's condition. Even if not required, I'd keep them for clearity. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html