On Mon, Dec 4, 2017 at 10:35 PM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Thu, Nov 30, 2017 at 10:36:55PM +0100, Philippe Ombredanne wrote: >> Jagan, >> >> On Thu, Nov 30, 2017 at 7:42 PM, Jagan Teki <jagannadh.teki@xxxxxxxxx> wrote: >> [] >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts >> > new file mode 100644 >> > index 0000000..f5303a3 >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts >> > @@ -0,0 +1,244 @@ >> > +/* >> > + * Copyright (C) 2017 Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> > + * >> > + * This file is dual-licensed: you can use it either under the terms >> > + * of the GPL or the X11 license, at your option. Note that this dual >> > + * licensing only applies to this file, and not this project as a >> > + * whole. >> > + * >> > + * a) This library is free software; you can redistribute it and/or >> > + * modify it under the terms of the GNU General Public License as >> > + * published by the Free Software Foundation; either version 2 of the >> > + * License, or (at your option) any later version. >> > + * >> > + * This library is distributed in the hope that it will be useful, >> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> > + * GNU General Public License for more details. >> > + * >> > + * Or, alternatively, >> > + * >> > + * b) Permission is hereby granted, free of charge, to any person >> > + * obtaining a copy of this software and associated documentation >> > + * files (the "Software"), to deal in the Software without >> > + * restriction, including without limitation the rights to use, >> > + * copy, modify, merge, publish, distribute, sublicense, and/or >> > + * sell copies of the Software, and to permit persons to whom the >> > + * Software is furnished to do so, subject to the following >> > + * conditions: >> > + * >> > + * The above copyright notice and this permission notice shall be >> > + * included in all copies or substantial portions of the Software. >> > + * >> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> > + * OTHER DEALINGS IN THE SOFTWARE. >> > + */ >> >> Rather than this long boilerplate, you might want to use the SPDX ids, >> as started by Greg and documented by Thomas. >> Noe that Linus wants the // comment style for the license line, and >> since there is only two line left here I suggest using it for both >> lines. >> You can check also the recent doc patch posted by Thomas (tglx) and >> comments from Linus and Greg. >> >> So I guess you could use this: >> >> > +// Copyright (C) 2017 Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> > +// SPDX-License-Indentifier: (GPL-2.0+ OR MIT) > > Other way around. Make SPDX-License-Indentifier the first line. My bad. 100% right! >> NB: what you call X11 is has the MIT license id in the SPDX license list. > > Right. That was a common mistake or abiguity in the dts files. > >> So you could replace 32 lines by only two lines :) it'[s neat right? >> >> And this would also help as we have tagged already ~15K files, so it >> would help to use this for new files so the amount of cleanup work >> still left does not increase. Thank you for your kind consideration! > > I've been nuging folks to do that for a while now. Of course, now we > need to go move the ids to the first line at some point. That's great: if you need some help there I have a tool that can help detect license and eventually inject a proper SPDX id [1] btw Thomas (tglx) posted a new patch set with the updated documentation. [1] https://github.com/nexB/scancode-toolkit/tree/833-espedexify -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
